Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go to v1.21 #1035

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Bump Go to v1.21 #1035

merged 1 commit into from
Dec 21, 2023

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Dec 21, 2023

Description of your changes

This PR bumps the Go version used in the CI pipelines and in the Go module to v1.21 in preparation for the Terraform provider bump.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Via an uptest run: https://github.com/upbound/provider-aws/actions/runs/7291718665

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
@ulucinar
Copy link
Collaborator Author

/test-examples="examples/ec2/vpc.yaml"

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar LGTM!

@ulucinar
Copy link
Collaborator Author

ulucinar commented Dec 21, 2023

Uptest run has failed because the Go version used in the main branch for uptest runs is still 1.20. Will trigger another run after merging this PR.

Edit: uptest succeeded here: https://github.com/upbound/provider-aws/actions/runs/7291718665

@ulucinar ulucinar merged commit 32fbf9a into crossplane-contrib:main Dec 21, 2023
9 of 10 checks passed
@ulucinar ulucinar deleted the bump-go-v1.21 branch December 21, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants